Re: Unsafe use of relation->rd_options without checking its type

Поиск
Список
Период
Сортировка
От Peter Geoghegan
Тема Re: Unsafe use of relation->rd_options without checking its type
Дата
Msg-id CAM3SWZRd91khYibv8Ya+Ab1KUOBgFtPbpfUS8_Tv35vvvfWN3Q@mail.gmail.com
обсуждение исходный текст
Ответ на Unsafe use of relation->rd_options without checking its type  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Mon, Oct 31, 2016 at 11:57 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Now that I've seen this I wonder which other uses of rd_options are
> potentially broken.  RelationIsUsedAsCatalogTable() is hardly the
> only macro that is assuming with little justification that it's
> applied to the right kind of reloptions.

It seems worth adding an assertion, at least. I wonder what running
the regression tests with a bunch of similar assertions shows up...


-- 
Peter Geoghegan



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Unsafe use of relation->rd_options without checking its type
Следующее
От: Jim Nasby
Дата:
Сообщение: Fix bug in handling of dropped columns in pltcl triggers