<div dir="ltr">Hi Pavel,<br /><br />Patch does look good to me. And found no issues as such.<br /><br />However here
aremy optional suggestions:<br /><br />1. Frankly, I did not like name of the function "row_to_json_pretty_choosy".<br
/>Something like "row_to_json_pretty_ignore_nulls" seems better to me.<br /><br />2. To use ignore nulls feature, I
haveto always pass pretty flag.<br />Which seems weired.<br /><br />Since we do support named argument, can we avoid
that?<br/> No idea how much difficult it is. If we have a default arguments to this<br />function then we do not need
oneand two argument variations for this<br />function as well. And we can use named argument for omitting the
required<br/> one. Just a thought.<br /><br />Rest looks good to me.<br /><br />Thanks<br /><div
class="gmail_extra"><br/>-- <br /><div dir="ltr">Jeevan B Chalke<br />Principal Software Engineer, Product
Development<br/>EnterpriseDB Corporation<br />The Enterprise PostgreSQL Company<br /><br /></div></div></div>