Re: checking variadic "any" argument in parser - should be array

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: checking variadic "any" argument in parser - should be array
Дата
Msg-id CAM2+6=WMSriUBADLqSx=y62P99SJG5UkW3UUaVnzNm6jiLvq2g@mail.gmail.com
обсуждение исходный текст
Ответ на checking variadic "any" argument in parser - should be array  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: checking variadic "any" argument in parser - should be array  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Pavel


On Sat, Jan 26, 2013 at 9:22 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hello Tom

you did comment

! <----><------><------> * Non-null argument had better be an array.
The parser doesn't
! <----><------><------> * enforce this for VARIADIC ANY functions
(maybe it should?), so
! <----><------><------> * that check uses ereport not just elog.
! <----><------><------> */

So I moved this check to parser.

It is little bit stricter - requests typed NULL instead unknown NULL,
but it can mark error better and early

Tom suggested that this check should be better done by parser.
This patch tries to accomplish that.

I will go review this.

However, is it possible to you to re-base it on current master? I can't apply it using "git apply" but patch -p1 was succeeded with lot of offset.

Thanks
 

Regards

Pavel


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers




--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Review: Patch to compute Max LSN of Data Pages
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Improvement of checkpoint IO scheduler for stable transaction responses