Re: [PATCH] Filter error log statements by sqlstate

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: [PATCH] Filter error log statements by sqlstate
Дата
Msg-id CAM2+6=VOuVf6_U8NtGpYz9Mfen=fdKcdgNskO_dKPnsvnpg4tw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Filter error log statements by sqlstate  (Oskari Saarenmaa <os@ohmu.fi>)
Список pgsql-hackers
Hi Oskari,

Patch looks good to me now. I have found no issues too. It is good to go in
now.

However, few small suggestions:

1. Whenever we know that a variable is containing only 32 bits, better define
it as uint32 and not just int (m_sqlstate in get_sqlstate_error_level()
function). int size may differ in size on different platforms.
2. Also always cast the results with the actual return type of the function.

These are my views. Current code has absolutely no issues as such (at least on
my machine).

Assigning back to you for your views on above points. If you are agree resend
the patch with changes else feel free to mark it as "Ready for Committor".

Thanks


--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it
Следующее
От: Stephen Frost
Дата:
Сообщение: Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it