Re: patch: option --if-exists for pg_dump

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: patch: option --if-exists for pg_dump
Дата
Msg-id CAM2+6=Uv3NpZgvnquN7ehbmeomduhRXRvJmijbeqN2i=8iPRgQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Pavel,


Ok. Good.
Sorry I didn't update my sources. Done now. Thanks
 
 

Also, I didn't quite understand these lines of comments:

                        /*
                         * Descriptor string (te-desc) should not be same as object
                         * specifier for DROP STATEMENT. The DROP DEFAULT has not
                         * IF EXISTS clause - has not sense.
                         */

Will you please rephrase ?

I can try it - .

A content of te->desc is usually substring of DROP STATEMENT with one related exception - CONSTRAINT.
Independent to previous sentence - ALTER TABLE ALTER COLUMN DROP DEFAULT doesn't support IF EXISTS - and therefore it should not be injected.

is it ok?

Fine with me.

Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Christian Kruse
Дата:
Сообщение: Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()
Следующее
От: Jeevan Chalke
Дата:
Сообщение: Re: [PATCH] Filter error log statements by sqlstate