Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Дата
Msg-id CALj2ACWis2_3eXO3WdscjrhGgXnMUNtQjXea9va7Vi5JHvNYpQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c  ("Euler Taveira" <euler@eulerto.com>)
Список pgsql-hackers
On Mon, Sep 13, 2021 at 6:45 AM Euler Taveira <euler@eulerto.com> wrote:
>
> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>
> nitpick: It looks like there's an extra set of parentheses around
> errmsg().
>
> Indeed. Even the requirement for extra parenthesis around auxiliary function
> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

The same commit says that the new code can be written in any way.
Having said that, I will leave it to the committer to take a call on
whether or not to remove the extra parenthesis.
   "
    While new code can be written either way, code intended to be
    back-patched will need to use extra parens for awhile yet.
    "

Regards,
Bharath Rupireddy.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: TAP test for recovery_end_command
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c