Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Дата
Msg-id CALj2ACWVhxvUjp84a1Ng-Z05cPK0HmsY8Q8DW8LaQFdpLrsbbA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included  (Julien Rouhaud <rjuju123@gmail.com>)
Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Список pgsql-hackers
On Sun, Jan 30, 2022 at 1:07 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2022-Jan-29, Bharath Rupireddy wrote:
>
> > Removing the xloginsert.h in xlog.h would need us to add xloginsert.h
> > in more areas.
>
> Sure.
>
> > And also, it might break any non-core extensions that
> > includes just xlog.h and gets xloginsert.h.
>
> That's a pretty easy fix anyway -- it's not even version-specific, since
> the fix would work with the older versions.  It's not something that
> would break on a minor version, either.

Here's the v3 patch removing xloginsert.h from xlog.h and adding
xloginsert.h in the required files.

Regards,
Bharath Rupireddy.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: Schema variables - new implementation for Postgres 15
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included