Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Дата
Msg-id CALj2ACWRfR-gRpno5eE1oo8twC4sfode0odsh2_DStNtM-YvHw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (vignesh C <vignesh21@gmail.com>)
Ответы Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (vignesh C <vignesh21@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
Thanks Rushabh and Vignesh for the comments.

>
> One comment:
> We could change below code:
> + */
> + if (!cstate->binary)
> + cstate->raw_buf = (char *) palloc(RAW_BUF_SIZE + 1);
> + else
> + cstate->raw_buf = NULL;
> to:
> cstate->raw_buf = (cstate->binary) ? NULL : (char *) palloc(RAW_BUF_SIZE + 1);
>

Attached the patch with the above changes.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "David G. Johnston"
Дата:
Сообщение: Re: [PATCH] postgres_fdw connection caching - cause remote sessionslinger till the local session exit
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: xid wraparound danger due to INDEX_CLEANUP false