Re: Inaccurate error message when set fdw batch_size to 0

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: Inaccurate error message when set fdw batch_size to 0
Дата
Msg-id CALj2ACWAqiNKFvvTpDxs5PHxGykQGcTB2FsU+Q=63BAx6LY+9A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Inaccurate error message when set fdw batch_size to 0  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Ответы Re: Inaccurate error message when set fdw batch_size to 0
Список pgsql-hackers
On Mon, Jul 12, 2021 at 10:11 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Mon, Jul 12, 2021 at 9:20 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> > +  <simplesect>
> > +   <title>Avoid Using <quote>non-negative</quote> Word in Error Messages</title>
> > +
> > +   <para>
> > +    Do not use <quote>non-negative</quote> word in error messages as it looks
> > +    ambiguous. Instead, use <quote>foo must be an integer value greater than zero</quote>
> > +    or  <quote>foo must be an integer value greater than or equal to zero</quote>
> > +    if option <quote>foo</quote> expects an integer value.
> > +   </para>
> > +  </simplesect>
> >
> > It seems suitable to put this guide under "Tricky Words to Avoid"
> > rather than adding it as separate section. Thought?
>
> +1. I will change.

PSA v7 patch with the above change.

Regards,
Bharath Rupireddy.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: Re: [PATCH] Use optimized single-datum tuplesort in ExecSort
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep