Re: definition of CalculateMaxmumSafeLSN

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: definition of CalculateMaxmumSafeLSN
Дата
Msg-id CALj2ACVo1WFLLYsQhfbH+aSPVYFdT0qVtTuBDVgr9upG33NvYQ@mail.gmail.com
обсуждение исходный текст
Ответ на definition of CalculateMaxmumSafeLSN  (Sergei Kornilov <sk@zsrv.org>)
Ответы Re: definition of CalculateMaxmumSafeLSN  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения 
On Mon, Feb 28, 2022 at 7:31 PM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
>
> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this
line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"

+1 to remove. Although the change is straightforward, I attached the
patch just for the sake of convention. I've marked it as RfC
https://commitfest.postgresql.org/38/3616/.

Just for the record - there's another thread
https://www.postgresql.org/message-id/CALj2ACVoQ7NEf43Xz0rfxsGOKYTN5r4VZp2DO2_5p%2BCMzsRPFw%40mail.gmail.com

Regards,
Bharath Rupireddy.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Следующее
От: Ranier Vilela
Дата:
Сообщение: Re: check for null value before looking up the hash function