Re: correct the sizes of values and nulls arrays in pg_control_checkpoint

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Дата
Msg-id CALj2ACUjFq6MWcbjOi01zAgeKcpO0DTDO8wf6qOprJHmx9ukDA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: correct the sizes of values and nulls arrays in pg_control_checkpoint  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Список pgsql-hackers
On Thu, Dec 23, 2021 at 9:16 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Thu, Dec 23, 2021 at 9:13 PM Euler Taveira <euler@eulerto.com> wrote:
> >
> > On Thu, Dec 23, 2021, at 8:39 AM, Bharath Rupireddy wrote:
> >
> > pg_control_checkpoint emits 18 columns whereas the values and nulls
> > arrays are defined to be of size 19. Although it's not critical,
> > attaching a tiny patch to fix this.
> >
> > Good catch! I'm wondering if a constant wouldn't be useful for such case.
>
> Thanks. I thought of having a macro, but it creates a lot of diff with
> the previous versions as we have to change for other pg_control_XXX
> functions.

I've added a CF entry to not lose track -
https://commitfest.postgresql.org/36/3475/

Regards,
Bharath Rupireddy.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Be clear about what log_checkpoints emits in the documentation
Следующее
От: Ashutosh Bapat
Дата:
Сообщение: Re: Add new function to convert 32-bit XID to 64-bit