Avoid unnecessary table open/close for TRUNCATE foo, foo, foo; kind of commands

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Avoid unnecessary table open/close for TRUNCATE foo, foo, foo; kind of commands
Дата
Msg-id CALj2ACUdBO_sXJTa08OZ0YT0qk7F_gAmRa9hT4dxRcgPS4nsZA@mail.gmail.com
обсуждение исходный текст
Ответы Re: Avoid unnecessary table open/close for TRUNCATE foo, foo, foo; kind of commands
Список pgsql-hackers
Hi,

While checking the ExecuteTruncate code for the FOREIGN TRUNCATE
feature, I saw that we filter out the duplicate relations specified in
the TRUNCATE command. But before skipping the duplicates, we are just
opening the relation, then if it is present in the already seen
relids, then closing it and continuing further.

I think we can just have the duplicate checking before table_open so
that in cases like TRUNCATE foo, foo, foo, foo; we could save costs of
table_open and table_close. Attaching a small patch. Thoughts?

This is just like what we already do for child tables, see following
in ExecuteTruncate:
            foreach(child, children)
            {
                Oid            childrelid = lfirst_oid(child);

                if (list_member_oid(relids, childrelid))
                    continue;

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kohei KaiGai
Дата:
Сообщение: Re: TRUNCATE on foreign table
Следующее
От: Amul Sul
Дата:
Сообщение: Re: Avoid unnecessary table open/close for TRUNCATE foo, foo, foo; kind of commands