On Sat, Jul 24, 2021 at 3:20 AM Cary Huang <cary.huang@highgo.ca> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> Hi
>
> I have applied and run your patch, which works fine in my environment. Regarding your comments in the patch:
Thanks for the review.
> /*
> * Restarting a sequence while defining it doesn't make any sense
> * and it may override the START value. Allowing both START and
> * RESTART option for CREATE SEQUENCE may cause confusion to user.
> * Hence, we throw error for CREATE SEQUENCE if RESTART option is
> * specified. However, it can be used with ALTER SEQUENCE.
> */
>
> I would remove the first sentence, because it seems like a personal opinion to me. I am sure someone, somewhere may
thinkit makes total sense :).
Agree.
> I would rephrase like this:
>
> /*
> * Allowing both START and RESTART option for CREATE SEQUENCE
> * could override the START value and cause confusion to user. Hence,
> * we throw an error for CREATE SEQUENCE if RESTART option is
> * specified; it can only be used with ALTER SEQUENCE.
> */
>
> just a thought.
LGTM. PSA v2 patch.
Regards,
Bharath Rupireddy.