Re: Refactoring postgres_fdw code to rollback remote transaction

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: Refactoring postgres_fdw code to rollback remote transaction
Дата
Msg-id CALj2ACUJALFeJ6+BcKeFnHAY9SG+WBM+q7jT1_4JCp_2kW3b3Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Refactoring postgres_fdw code to rollback remote transaction  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Ответы Re: Refactoring postgres_fdw code to rollback remote transaction  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Список pgsql-hackers
On Fri, Sep 17, 2021 at 8:28 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> On 2021/09/17 11:40, Zhihong Yu wrote:
> > +           goto fail;          /* Trouble clearing prepared statements */
> >
> > The label fail can be removed. Under the above condition,  entry->changing_xact_state is still true. You can
directlyreturn.
 
>
> Thanks for the review! Yes, you're right. Attached the updated version of the patch.

+1 for the code refactoring (1 file changed, 75 insertions(+), 102
deletions(-)).

The v2 patch looks good to me as is.

Regards,
Bharath Rupireddy.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "houzj.fnst@fujitsu.com"
Дата:
Сообщение: RE: Logical replication keepalive flood
Следующее
От: Peter Smith
Дата:
Сообщение: Re: Logical replication keepalive flood