On Thu, Aug 22, 2019 at 1:14 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
The patch also includes a little unit test module to test this without creating a 16 TB table. A whole new test module seems a bit like overkill just for this, but clearly we were missing test coverage here. And it will come handy, if we want to invent a new better posting list format in the future. Thoughts on whether to include the test module or not?
I like the test as importantly adds missing coverage. Also, really simplifies validation effort if required to make change in this area anytime in future. So, I would +1 keeping the same.