On Tue, Apr 9, 2019 at 6:17 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
On 08/04/2019 20:37, Andres Freund wrote: > On 2019-04-08 15:34:46 +0300, Heikki Linnakangas wrote: >> There's a little bug in index-only scan executor node, where it mixes up the >> slots to hold a tuple from the index, and from the table. That doesn't cause >> any ill effects if the AM uses TTSOpsHeapTuple, but with my toy AM, which >> uses a virtual slot, it caused warnings like this from index-only scans: > > Hm. That's another one that I think I had fixed previously :(, and then > concluded that it's not actually necessary for some reason. Your fix > looks correct to me. Do you want to commit it? Otherwise I'll look at > it after rebasing zheap, and checking it with that.
I found another slot type confusion bug, while playing with zedstore. In an Index Scan, if you have an ORDER BY key that needs to be rechecked, so that it uses the reorder queue, then it will sometimes use the reorder queue slot, and sometimes the table AM's slot, for the scan slot. If they're not of the same type, you get an assertion: