Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
| От | Kirill Reshke |
|---|---|
| Тема | Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist |
| Дата | |
| Msg-id | CALdSSPifaAAiOe8LqTJCAcuJ9BMnpQsEPnCojDMGHsUopWjoXA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist
|
| Список | pgsql-hackers |
On Tue, 30 Dec 2025 at 00:24, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Kirill Reshke <reshkekirill@gmail.com> writes: > > Should we then refactor code to avoid copying? I copied this code in > > [0] for the third time, so if this has a chance to be committed, there > > will be 3 times copied code... > > Might not be a bad idea, but of course the devil is in the details. > What did you have in mind? Split out a function to quote one > field value per record_out's rules? > > regards, tom lane Yes, split out a function that does quoting after OidOutputFunctionCall. that is, this: https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/rowtypes.c#L437-L464 -- Best regards, Kirill Reshke
В списке pgsql-hackers по дате отправления: