Re: processes stuck in shutdown following OOM/recovery

On Wed, 6 Mar 2024 at 02:22, Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Sat, Dec 2, 2023 at 3:30 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Sat, Dec 2, 2023 at 2:18 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > > On Fri, Dec 1, 2023 at 6:13 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > > > $ kill -9 2524495; sleep 0.05; pg_ctl -D ./pgdev.dat1 stop -m fast # 2524495 is a child's pid
> > >
> > > > This affects v15, and fails at ) but not its parent.
> > >
> > > Repro'd here.  I had to make the sleep shorter on my system.  Looking...
> >
> > The PostmasterStateMachine() case for PM_WAIT_BACKENDS doesn't tell
> > the checkpointer to shut down in this race case.  We have
> > CheckpointerPID != 0 (because 7ff23c6d27 starts it earlier than
> > before), and FatalError is true because a child recently crashed and
> > we haven't yet received the PMSIGNAL_RECOVERY_STARTED handler that
> > would clear it.  Hmm.
>
> Here is a first attempt at fixing this.  I am not yet 100% sure if it
> is right, and there may be a nicer/simpler way to express the
> conditions.  It passes the test suite, and it fixes the repro that
> Justin posted.  FYI on my machine I had to use sleep 0.005 where he
> had 0.05, as an FYI if someone else is trying to reproduce the issue.

Hi!
This patch needs a rebase.CF entry status now is Waiting On author.

--
Best regards,
Kirill Reshke