Re: Using read_stream in index vacuum

On Mon, 18 Nov 2024 at 16:34, Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>
>
>
> > On 2 Nov 2024, at 02:36, Kirill Reshke <reshkekirill@gmail.com> wrote:
> >
> > I noticed CI failure for this patch. This does not look like a flap.
>
> Seems like vacuum did not start index cleanup. I’ve added "index_cleanup on".
> Thanks!
>
>
> Best regards, Andrey Borodin.

Hi!

0001 Looks mature. Some comments:
1)
>+# This ensures autovacuum do not run
>+$node->append_conf('postgresql.conf', 'autovacuum = off');
The other option is to set `autovacuum = off `in relation DDL. I'm not
sure which option is better.

2) Are these used?
my $psql_err = '';
my $psql_out = '';


Should we add tap testing to 0002 & 0003 like 0001 already has?


--
Best regards,
Kirill Reshke