On Sat, 3 Jan 2026 at 23:58, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>
>
>
> > On 3 Jan 2026, at 00:16, Kirill Reshke <reshkekirill@gmail.com> wrote:
> >
> > PFA v4 with typo fixes.
>
> Thanks!
>
> I think block size dependency is not a problem. There are no pageinspect tests that pass with 1Kb pages.
>
> I have some more nits:
>
> Meson build needs to be updated.
>
> Documentation is on a TODO list.
Done
> + relation_close(indexRel, AccessShareLock);
> Perhaps, index_close() is what you actually wanted?
Ok
> StringInfoData buf is leaked still, you can init it once and reset in the loop.
Ok
> tmpTupdesc recreation worth commenting on.
Ok
> Thanks!
>
>
> Best regards, Andrey Borodin.
PFA v6
--
Best regards,
Kirill Reshke