Re: remove reset_shared()

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: remove reset_shared()
Дата
Msg-id CALT9ZEH_v33xfJpNjY+BtrYpyvDqPZ8xHCdzjbK21S8XGAUJeQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: remove reset_shared()  (Maxim Orlov <orlovmg@gmail.com>)
Ответы Re: remove reset_shared()  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Fri, 15 Jul 2022 at 16:41, Maxim Orlov <orlovmg@gmail.com> wrote:
Hi!

In general I'm for this patch. Some time ago I was working on a patch related to shared memory and noticed 
no reason to have reset_shared() function.

Hi, hackers!
I see the proposed patch as uncontroversial and good enough to be committed. It will make the code a little clearer. Personally, I don't like leaving functions that are just wrappers for another and called only once. But I think that if there's a question of code readability it's not bad to restore the comments on the purpose of a call that were originally in the code. 

PFA v2 of a patch (only the comment removed in v1 is restored in v2).

Overall I'd like to move it to RfC if none have any objections.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Maxim Orlov
Дата:
Сообщение: Re: remove reset_shared()
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Allowing REINDEX to have an optional name