Re: Table AM Interface Enhancements
| От | Pavel Borisov |
|---|---|
| Тема | Re: Table AM Interface Enhancements |
| Дата | |
| Msg-id | CALT9ZEHLPS8ZJVH4MyszsH_-quxPgH_rh7ZuaVYiedHx_tnzqA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Table AM Interface Enhancements (Alexander Korotkov <aekorotkov@gmail.com>) |
| Ответы |
Re: Table AM Interface Enhancements
Re: Table AM Interface Enhancements |
| Список | pgsql-hackers |
Hi, Alexander!
For 0007:
Code inside
+heapam_reloptions(char relkind, Datum reloptions, bool validate)
+{
+ if (relkind == RELKIND_RELATION ||
+ relkind == RELKIND_TOASTVALUE ||
+ relkind == RELKIND_MATVIEW)
+ return heap_reloptions(relkind, reloptions, validate);
+
+ return NULL;
+ relkind == RELKIND_MATVIEW)
+ return heap_reloptions(relkind, reloptions, validate);
+
+ return NULL;
looks redundant to what is done inside heap_reloptions(). Was this on purpose? Is it possible to leave only "return heap_reloptions()" ?
This looks like a duplicate:
src/include/access/reloptions.h:extern bytea *index_reloptions(amoptions_function amoptions, Datum reloptions,
src/include/access/tableam.h:extern bytea *index_reloptions(amoptions_function amoptions, Datum reloptions,
src/include/access/tableam.h:extern bytea *index_reloptions(amoptions_function amoptions, Datum reloptions,
Otherwise the patch looks good and doing what it's proposed to do.
Regards,
Pavel Borisov.
В списке pgsql-hackers по дате отправления: