Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Дата
Msg-id CALT9ZEHL2DJ9u=z6QRnWri-h4Vs0j+DgKML=Y15CehgwfT1Kfg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.  (Mark Dilger <mark.dilger@enterprisedb.com>)
Список pgsql-hackers
Hi, Mark! 
> At the first glance it's not clear to me:
> - why your test creates cross-page unique constraint violations?

To see if they are detected.

> - how do you know they are not detected?

It appears that they are detected.  At least, rerunning the test after adjusting the expected output, I no longer see problems.

I understand your point. It was unclear how it modified the index so that only unique constraint check between pages should have failed with other checks passed. 

Anyway, thanks for your testing and efforts! I'm happy that the test now passes and confirms that amcheck feature works as intended.

Kind regards,
Pavel Borisov

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: commitfest.postgresql.org is no longer fit for purpose
Следующее
От: Jacob Champion
Дата:
Сообщение: Re: libpq compression (part 3)