Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl
Дата
Msg-id CALT9ZEF-EwaQ8R_7Eay2Vj7500UnHzJBRy7_iGDEEqY_cchqoA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl  (Maxim Orlov <orlovmg@gmail.com>)
Ответы Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl  (Maxim Orlov <orlovmg@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On Wed, Jul 6, 2022 at 5:05 PM Maxim Orlov <orlovmg@gmail.com> wrote:
Hi!

This is an obvious change, I totally for it. Hope it will be commited soon.
 
I'm sorry for some nitpicking about changes in the comments:
- The number of WAL segments advanced hasn't changed from 5 to 1, it just advances as 1+4 as previously. So the original comment is right. I reverted this in v2.
- wal_segment_size is in bytes so comment "(wal_segment_size * n) MB" is incorrect. I corrected this to bytes.

PFA  v2 of a patch (only comments changed/reverted to original).
Overall I completely agree with Maxim: the patch is good and simple enough to be RfC.

--
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [RFC] building postgres with meson -v9
Следующее
От: Maxim Orlov
Дата:
Сообщение: Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl