Re: [PATCH] fix GIN index search sometimes losing results

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: [PATCH] fix GIN index search sometimes losing results
Дата
Msg-id CALT9ZEET-eDJ-_nr0sKBTeSK8+wJQta1JXN2hugfWHCQrTyL9Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] fix GIN index search sometimes losing results  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [PATCH] fix GIN index search sometimes losing results  (Artur Zakirov <zaartur@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
ср, 1 июл. 2020 г. в 23:16, Tom Lane <tgl@sss.pgh.pa.us>:
Pavel Borisov <pashkin.elfe@gmail.com> writes:
> Below is my variant how to patch Gin-Gist weights issue:

I looked at this patch, but I'm unimpressed, because it's buggy.
 
Thank you, i'd noticed and made minor corrections in the patch. Now it should work 
correctly,

As for preserving the option to use legacy bool-style calls, personally I see much
value of not changing API ad hoc to fix something. This may not harm vanilla reseases 
but can break many possible side things like RUM index etc which I think are abundant 
around there. Furthermore if we leave legacy bool callback along with newly proposed and 
recommended for further use it will cost nothing.

So I've attached a corrected patch. Also I wrote some comments to the code and added 
your test as a part of apatch. Again thank you for sharing your thoughts and advice.

As always I'd appreciate everyone's opinion on the bugfix.

--
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Steele
Дата:
Сообщение: Re: Remove Deprecated Exclusive Backup Mode
Следующее
От: Konstantin Knizhnik
Дата:
Сообщение: Re: Built-in connection pooler