Re: Patch to avoid orphaned dependencies

For genam.c:

+   UseDirtyCatalogSnapshot = dirtysnap;
+

Does the old value of UseDirtyCatalogSnapshot need to be restored at the end of the func ?

+systable_recheck_tuple(SysScanDesc sysscan, HeapTuple tup, bool dirtysnap)

Considering that parameter dirtysnap is a bool, I think it should be named isdirtysnap so that its meaning can be distinguished from:

+   Snapshot dirtySnapshot;

+   UseDirtyCatalogSnapshot = true;
+
+   dirtySnapshot = GetCatalogSnapshot(RelationGetRelid(*depRel));

I tend to think that passing usedirtysnap (bool parameter) to GetCatalogSnapshot() would be more flexible than setting global variable.

Cheers