Re: Non-decimal integer literals

Поиск
Список
Период
Сортировка
От Zhihong Yu
Тема Re: Non-decimal integer literals
Дата
Msg-id CALNJ-vT2qZ-hbfDAjutsYXfR+ga1-KMKtU2vRC0UtKbFeHCPfg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Non-decimal integer literals  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Ответы Re: Non-decimal integer literals  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers


On Tue, Sep 7, 2021 at 4:13 AM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
On 16.08.21 17:32, John Naylor wrote:
> The one thing that jumped out at me on a cursory reading is
> the {integer} rule, which seems to be used nowhere except to
> call process_integer_literal, which must then inspect the token text to
> figure out what type of integer it is. Maybe consider 4 separate
> process_*_literal functions?

Agreed, that can be done in a simpler way.  Here is an updated patch.
Hi,
Minor comment:

+SELECT int4 '0o112';

Maybe involve digits of up to 7 in the octal test case.

Thanks 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Justin Pryzby
Дата:
Сообщение: Re: when the startup process doesn't (logging startup delays)
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: Small documentation improvement for ALTER SUBSCRIPTION