Hi,
w.r.t. patch v27.
+ * The idea is to prepend underscores as needed until we make a name that
+ * doesn't collide with anything ...
I wonder if other characters (e.g. [a-z0-9]) can be used so that name without collision can be found without calling truncate_identifier().
+ else if (strcmp(defel->defname, "multirange_type_name") == 0)
+ {
+ if (multirangeTypeName != NULL)
+ ereport(ERROR,
+ (errcode(ERRCODE_SYNTAX_ERROR),
+ errmsg("conflicting or redundant options")));
Maybe make the error message a bit different from occurrences of similar error message (such as including multirangeTypeName) ?
Thanks