Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options

Поиск
Список
Период
Сортировка
От Zhihong Yu
Тема Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Дата
Msg-id CALNJ-vRLJBiV8OnoFkF-TYqFtCsY=7+kr69WJ7N1RSGgqWEhJQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers


On Mon, Oct 17, 2022 at 5:05 PM David Rowley <dgrowleyml@gmail.com> wrote:
Thanks for having a look at this.

On Fri, 14 Oct 2022 at 10:52, Zhihong Yu <zyu@yugabyte.com> wrote:
> +       req->frameOptions = (FRAMEOPTION_ROWS |
> +                            FRAMEOPTION_START_UNBOUNDED_PRECEDING |
> +                            FRAMEOPTION_END_CURRENT_ROW);
>
> The bit combination appears multiple times in the patch.
> Maybe define the combination as a constant in supportnodes.h and reference it in the code.

I don't believe supportnodes.h has any business having any code that's
related to actual implementations of the support request type.  If we
were to have such a definition then I think it would belong in
windowfuncs.c.  I'd rather see each implementation of the support
request spell out exactly what they mean, which is what the patch does
already.

David
Hi,
I am fine with keeping the code where it is now.

Cheers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Smith
Дата:
Сообщение: Re: Perform streaming logical transactions by background workers and parallel apply
Следующее
От: Laurenz Albe
Дата:
Сообщение: Re: [PATCH] Allow usage of archive .backup files as backup_label