Re: [pgAdmin][RM5653]: High Contrast UI Theme

Поиск
Список
Период
Сортировка
От Aradhana Birewar
Тема Re: [pgAdmin][RM5653]: High Contrast UI Theme
Дата
Msg-id CALL3v4AudNGXpFkEynpPxPe7HfZMppX-GEDdVyY=gR+nV1q6Rg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM5653]: High Contrast UI Theme  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Akshay,

As per the high contrast design theme, Grant Wizard dialog background color should be same as Maintenance dialog. 
Further, create table modal background color should be #1f2932, designed as per the other two themes.

Regards,
Aradhana

On Fri, Jul 17, 2020 at 1:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Nikhil

I have applied the patch and run the pgAdmin in High Contrast Theme. Following issues, I have found 
  • Add (Beta) suffix in "High Contrast" in the preferences dialog. 
  • Update the documentation for High Contrast Theme in Preferences.
  • Three different colors used for dialog header (Properties, Grant Wizard, Maintenance). Refer the below screenshot 
                            Dialog Border Color.png

@Aradhana Birewar Can we use the same light blue color for the properties, grant wizard, and maintenance dialog?
  • In the Query History tab, SQL is not readable. Refer the below screenshot          
                           Query_History.png

Aditya is doing the code review so wait for his review comments and then send the combined patch.


On Fri, Jul 17, 2020 at 12:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Aditya, can you please do the code review.

On Thu, Jul 16, 2020 at 6:54 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have completed changes for the support of the new High-Contrast  UI Theme RM-#5653.

PFA patch.


Regards,
Nikhil Mohite.



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][RM5653]: High Contrast UI Theme
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Fix typo