Re: 024_add_drop_pub.pl might fail due to deadlock

On Tue, 29 Jul 2025 at 14:46, Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Tue, Jul 29, 2025 at 1:13 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Yes, that makes sense to me. For HEAD and PG18, we can still add a new
> > argument to the API. For other bank branches, it is better to use a
> > new Ex function as suggested by Kuroda-San.
> >
>
> Here are the updated patches.

The only case where the ordering of lock now is different is in
DropSubscription, but in this case we take an AccessExclusiveLock on
pg_subscription which should prevent this deadlock from occurring:
...
replorigin_drop_by_name(originname, true, false);
}

/* Clean up dependencies */
deleteSharedDependencyRecordsFor(SubscriptionRelationId, subid, 0);

/* Remove any associated relation synchronization states. */
RemoveSubscriptionRel(subid, InvalidOid);
...

Regards,
Vignesh