On Mon, Jul 4, 2022 at 7:44 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> > From d8f8844f877806527b6f3f45320b6ba55a8e3154 Mon Sep 17 00:00:00 2001
> > From: Vigneshwaran C <vignesh21@gmail.com>
> > Date: Thu, 26 May 2022 19:29:33 +0530
> > Subject: [PATCH v27 1/4] Add a missing test to verify only-local parameter in
> > test_decoding plugin.
> >
> > Add a missing test to verify only-local parameter in test_decoding plugin.
>
> I don't get it. replorigin.sql already has some lines to test
> local-only. What is your patch adding that is new? Maybe instead of
> adding some more lines at the end of the script, you should add lines
> where this stuff is already being tested. But that assumes that there
> is something new that is being tested; if so what is it?
The test is to check that remote origin data (i.e. replication origin
being set) will be filtered when only-local parameter is set. I felt
that this scenario is not covered, unless I'm missing something. I
have moved the test as suggested.
I have changed this in the v28 patch attached at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm3MNK2hMYroTiHGS9HkSxiA-az1QC1mpa0YwDZ8nGmmZg%40mail.gmail.com
Regards,
Vignesh