On Tue, Nov 9, 2021 at 2:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Nov 9, 2021 at 7:20 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > FYI - I spotted a trivial SQL mistake (?) of the schema publication patch [1].
> >
> > See the file describe.c, function describeOneTableDetails.
> > The new SQL has a 3rd UNION that looks like:
> >
> > ...
> > "UNION\n"
> > "SELECT pubname\n"
> > "FROM pg_catalog.pg_publication p\n"
> > "WHERE puballtables AND pg_catalog.pg_relation_is_publishable('%s')\n"
> > "ORDER BY 1;",
> > oid, oid, oid, oid);
> >
> > Notice that there is a table alias "p" but it is never used. It seems
> > to me like it is just an accidental omission. I think it should be
> > written like -
> >
> > BEFORE:
> > "WHERE puballtables AND pg_catalog.pg_relation_is_publishable('%s')\n"
> > AFTER:
> > "WHERE p.puballtables AND pg_catalog.pg_relation_is_publishable('%s')\n"
> >
> > Doing this will make it consistent with the SQL of the nearby "else"
> > case which uses the same alias as expected.
> >
>
> The above makes sense to me. So, pushed a fix for this along with
> Vignesh's patch to fix other comments related to this work.
Thanks for committing the patch. I have changed the status of the
Commitfest entry for this patch to Committed. Adding of the view can
be handled once the Sequence patch is committed.
Regards,
Vignesh