Re: Logical Replication of sequences

On Fri, 3 Jan 2025 at 09:07, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh,
>
> Some minor review comments for the patch v20241230-0003.
>
> ======
> src/backend/replication/logical/syncutils.c
>
> 1.
> + * syncutils.c
> + *   PostgreSQL logical replication: common synchronization code
> + *
> + * Copyright (c) 2024, PostgreSQL Global Development Group
>
> Happy New Year.
>
> s/2024/2025/

Modified

> ~~~
>
> 2.
> +/*
> + * Enum representing the overall state of subscription relations state.
> + *
> + * SYNC_RELATIONS_STATE_NEEDS_REBUILD indicates that the subscription relations
> + * state is no longer valid and the subscription relations should be rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_REBUILD_STARTED indicates that the subscription
> + * relations state is being rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_VALID indicates that subscription relation state is
> + * up-to-date and valid.
> + */
>
> 2a.
> That first sentence saying "overall state of [...] state" is a bit strange.
>
> Maybe it can be reworded something like:
> Enum for phases of the subscription relations state.

Modified

> ~
>
> 2b.
> /is no longer valid and/is no longer valid, and/

Modified

>
> 2c.
> /that subscription relation state is up-to-date/that the subscription
> relation state is up-to-date/

Modified

The changes for the same are available at the v20250204 version patch
attached at [1].

[1] - https://www.postgresql.org/message-id/CALDaNm07EtT7zQXhjvaX7AKUv_gKMsrSYxJQmmOHhpCZpvV07w%40mail.gmail.com

Regards,
Vignesh