On Sun, Oct 20, 2019 at 1:20 AM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
> index f9fe57f..6224735 100644
> --- a/contrib/bloom/blcost.c
> +++ b/contrib/bloom/blcost.c
> @@ -12,10 +12,10 @@
> */
> #include "postgres.h"
>
> +#include "bloom.h"
> #include "fmgr.h"
> #include "utils/selfuncs.h"
>
> -#include "bloom.h"
>
> /*
> * Estimate cost of bloom index scan.
>
> This class of change I don't like.
>
> The existing arrangement keeps "other" header files separate from the
> header file of the module itself. It seems useful to keep that separate.
>
Thanks Peter for your thoughts, I have modified the changes based on
your suggestions.
I have included the module header file in the beginning.
The changes are attached in the previous mail.
Please let me know your suggestions for any changes.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com