On Fri, Jul 10, 2020 at 8:51 AM Amit Langote <amitlangote09@gmail.com> wrote:
>
> Hi Bharath,
> Here the numbers with the updated patch:
>
> HEAD patched (v2)
> foo5 8.5 6.1
> foo10 14 9.4
> foo20 25 16.7
>
Patch applies cleanly, make check & make check-world passes.
I had reviewed the changes. I felt one minor change required:
+ * CopyReadFromRawBuf
+ * Reads 'nbytes' bytes from cstate->copy_file via
cstate->raw_buf and
+ * writes then to 'saveTo'
+ *
+ * Useful when reading binary data from the file.
Should "writes then to 'saveTo'" be "writes them to 'dest'"?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com