On Mon, Oct 21, 2019 at 8:47 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sun, Oct 20, 2019 at 10:58 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > On Thu, Oct 17, 2019 at 4:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > >
> > > I haven't reviewed it completely, but generally, the changes seem to
> > > be fine. Please see if you can be consistent in extra space between
> > > includes. Kindly check the same throughout the patch.
> > >
> > Thanks for reviewing the patch.
> > I have made an updated patch with comments you have suggested.
> > I have split the patch into 3 patches so that the review can be simpler.
> > This patch also includes the changes suggested by Peter & Andres.
> > I had just seen seen Tom Lane's suggestions regarding submodule header
> > file, this patch contains fix based on Andres suggestions. Let me know
> > if that need to be changed, I can update it.
> >
>
> AFAICS, none of Andres or Tom seems to be in favor of separating
> module headers. I am also not sure if we should try to make sure of
> that in every case.
>
Thanks for the suggestions.
Updated patch contains the fix based on Tom Lane's Suggestion.
Let me know your thoughts for further revision if required.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com