On Tue, 3 Jan 2023 at 16:01, vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, 29 Nov 2022 at 00:57, Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> > > On 28 Nov 2022, at 20:02, Nikolay Shaplov <dhyan@nataraj.su> wrote:
> >
> > > From my reviewer's point of view patch is ready for commit.
> > >
> > > Thank you for your patience :-)
> >
> > Thanks for review.
> >
> > The attached tweaks a few comments and attempts to address the compiler warning
> > error in the CFBot CI. Not sure I entirely agree with the compiler there but
> > here is an attempt to work around it at least (by always copying the va_list
> > for the logfile). It also adds a missing va_end for the logfile va_list.
> >
> > I hope this is close to a final version of this patch (commitmessage needs a
> > bit of work though).
> >
> > > PS Should I change commitfest status?
> >
> > Sure, go ahead.
> >
>
> The patch does not apply on top of HEAD as in [1], please post a rebased patch:
> === Applying patches on top of PostgreSQL commit ID
> 92957ed98c5c565362ce665266132a7f08f6b0c0 ===
> === applying patch
> ./v14-0001-Change-pg_regress-output-format-to-be-TAP-compli.patch
> patching file meson.build
> Hunk #1 FAILED at 2968.
> 1 out of 1 hunk FAILED -- saving rejects to file meson.build.rej
Attached a rebased patch on top of HEAD to try and see if we can close
this patch in this commitfest.
Regards,
Vignesh