Re: Avoid updating inactive_since for invalid replication slots

Поиск
Список
Период
Сортировка
От vignesh C
Тема Re: Avoid updating inactive_since for invalid replication slots
Дата
Msg-id CALDaNm0QFB1C6xVKfpS2FtPwBbxW0W-yRh9nOCdzGY=EvAd=Dg@mail.gmail.com
обсуждение исходный текст
Ответы Re: Avoid updating inactive_since for invalid replication slots
Список pgsql-hackers
On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> Here is the v2 patch with above change and other comments from [1] and
> [2] incorporated.

One small suggestion:
Since we will not be retaining inactive time for invalid slots after
server restart, the inactive time will be lost in this case, shouldn't
we include mentioning that too:
         The time when the slot became inactive. <literal>NULL</literal> if the
-        slot is currently being streamed.
+        slot is currently being streamed. If the slot becomes invalid,
+        this value will not be updated.

Regards,
Vignesh



В списке pgsql-hackers по дате отправления: