On Fri, Dec 3, 2021 at 11:24 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Thursday, December 2, 2021 4:54 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote:
> > On Thursday, December 2, 2021 12:50 PM Amit Kapila
> > <amit.kapila16@gmail.com> wrote:
> > > On Thu, Dec 2, 2021 at 9:41 AM Greg Nancarrow <gregn4422@gmail.com>
> > > wrote:
> > > >
> > > > On Thu, Dec 2, 2021 at 1:48 PM Greg Nancarrow <gregn4422@gmail.com>
> > > wrote:
> > > > >
> > > > > If you updated my original description to say "(instead of just
> > > > > the individual partitions)", it would imply the same I think.
> > > > > But I don't mind if you want to explicitly state both cases to make it clear.
> > > > >
> > > >
> > > > For example, something like:
> > > >
> > > > For publications of partitioned tables with
> > > > publish_via_partition_root set to true, only the partitioned table
> > > > (and not its partitions) is included in the view, whereas if
> > > > publish_via_partition_root is set to false, only the individual partitions are
> > included in the view.
> > > >
> > >
> > > Yeah, that sounds good to me.
> >
> > It looks good to me as well.
> > Attach the patches for (HEAD~13) which merge the suggested doc change. I
> > prepared the code patch and test patch separately to make it easier for
> > committer to confirm.
>
> It seems we might not need to backpatch the doc change, so
> attach another version which remove the doc changes from backpatch patches.
Thanks for the patches, the patch applies and the test passes in head
and the back branches. one minor suggestion:
1) Shall we change:
+ <para>
+ For publications of partitioned tables with
+ <literal>publish_via_partition_root</literal> set to
+ <literal>true</literal>, only the partitioned table (and not its partitions)
+ is included in the view, whereas if
+ <literal>publish_via_partition_root</literal> is set to
+ <literal>false</literal>, only the individual partitions are included in the
+ view.
+ </para>
To:
+ <para>
+ For publications of partitioned tables with
+ <literal>publish_via_partition_root</literal> set to
+ <literal>true</literal>, only the partitioned table (and not its partitions)
+ is included in the view, whereas if
+ <literal>publish_via_partition_root</literal> is set to
+ <literal>false</literal>, only the individual partitions (and not the
+ partitioned table) are included in the
+ view.
+ </para>
2) Any particular reason why the code and tests are backbranched but
not the document changes?
Regards,
Vignesh