On Sun, Jun 16, 2013 at 9:59 PM, Jon Nelson <jnelson+pgsql@jamponi.net> wrote:
> On Fri, Jun 14, 2013 at 12:06 PM, Jeff Davis <pgsql@j-davis.com> wrote:
>> On Sat, 2013-05-25 at 13:55 -0500, Jon Nelson wrote:
..
>> * You check for the presence of posix_fallocate at configure time, but
>> don't #ifdef the call site. It looks like you removed this from the v2
>> patch, was there a reason for that? Won't that cause build errors for
>> platforms without it?
>
> Indeed! I believe I have corrected the error and will be sending out a
> revised patch (v5), once the performance and back-testing have
> completed.
Please find attached v5 of the patch, with the above correction in place.
The only change from the v4 patch is wrapping the if
(wal_use_fallocate) block in an #ifdef USE_POSIX_FALLOCATE.
Thanks!
--
Jon