Re: PATCH: Choose best width for Data Output columns of Query tool

Поиск
Список
Период
Сортировка
От Dinesh Kumar
Тема Re: PATCH: Choose best width for Data Output columns of Query tool
Дата
Msg-id CAKWsr7jOJ-UyvKq7Z6svd8ZBc-z1hSk5_ZW-MH3Hifzxz1_pAA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: Choose best width for Data Output columns of Query tool  ("J.F. Oster" <jinfroster@mail.ru>)
Ответы Re: PATCH: Choose best width for Data Output columns of Query tool
Список pgadmin-hackers
Дерево обсуждения
Hi,

On Thu, Dec 5, 2013 at 8:42 PM, J.F. Oster <jinfroster@mail.ru> wrote:
Hello Dinesh,

Thursday, December 5, 2013, 1:38:10 PM, you wrote:


DK> I have reviewed your patch and managed to traverse each line
DK> of your code, except "AutoColumn" function body. Could you give me
DK> some information, when the pgAdmin goes to this function call.

You mean AutoSizeColumn()? In fact it is used only in
ctlSQLGrid::OnLabelDoubleClick(). If user doubleclicks column label
holding Ctrl/Meta, the column's manual size is forgotten and this
function is called to resize that single column immediately (otherwise
the user wouldn't notice the effect until re-execution of query).

OK. Thank you.

@Dave:

It seems good to me. I might be wrong in some places in analyzing this patch, hence requesting you to look into this once.

Thanks in advance.

Regards,
Dinesh


DK> I have verified it in Mac/Linux/Windows, seems working fine. :)

Good news, thank you!

--
Best regards,
 Vadim


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: PATCH: Save & restore last active panel in Options dialogue
Следующее
От: Dinesh Kumar
Дата:
Сообщение: Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3