Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
| От | Manni Wood |
|---|---|
| Тема | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement |
| Дата | |
| Msg-id | CAKWEB6pRSKqpyOE1YgsnsfNDSNjqXukx4OptZFj71jOzNb=n7A@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement (Álvaro Herrera <alvherre@kurilemu.de>) |
| Список | pgsql-hackers |
On Mon, Nov 10, 2025 at 5:27 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
On 2025-Nov-08, Manni Wood wrote:
> However, I see that this
> https://cirrus-ci.com/task/6437176629526528?logs=clone#L214 checks out a
> specific commit on a specific branch:
>
> "Checked out db131410131cb6a60f074213b0e7aaaa15d72f87 on cf/6175 branch."
>
> My clone of postgres (which is presumably shallow?) does not show that
> branch, not even with "git branch -r".
Yeah, these branches used by CI are made up on the spot and aren't
propagated out of that repository. You can add a "remote" to your
existing clone,
git remote add cfbot https://github.com/postgresql-cfbot/postgresql.git
and then you can see the branches it creates and `git switch` to them.
Do mind that they are ephemeral, and for this thread they only contain
the patches you submitted yourself; really, this is only useful if
you're going to review other people's patches, and even then it might
still be better to use the patches from the mailing list (which is where
cfbot itself grabs them from anyway).
You should definitely be reviewing other people's patches, though, not
just because it's valuable for the community as a whole to have an
additional pair of eyes on them, but also because they can teach you
many things.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Oh, great altar of passive entertainment, bestow upon me thy discordant images
at such speed as to render linear thought impossible" (Calvin a la TV)
Thank you very much, Nishant, Jim, and Álvaro!
I will start building with both make and Meson before submitting patches. Lesson learned.
Also, Álvaro, yes, I do need to start reviewing patches this week.
Thanks, all!
-- -- Manni Wood EDB: https://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: