Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Поиск
Список
Период
Сортировка
От Murtuza Zabuawala
Тема Re: [pgAdmin4][Patch] To fix the issue in Debugger module
Дата
Msg-id CAKKotZSJwqs9Ajgc3ke4w2Kwkung2PkKUyew4_eEbu15Ti5iig@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] To fix the issue in Debugger module  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin4][Patch] To fix the issue in Debugger module  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Список pgadmin-hackers
Yes, I'm looking into it, I will send updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jun 23, 2017 at 2:32 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Yes Dave,
>
> You are right, I tested and found that indirect debugging is not working.
> But otherwise for direct debugging it works properly.

Does the patch take that into account, or are you modifying it?

> On Fri, Jun 23, 2017 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in Debugger module where it was unable to
>> > start
>> > debugging if 'plugin_debugger' can not found in
>> > shared_preload_libraries.
>> > RM#2162
>> >
>> > Original patch by: Kit Yam Tse
>> > (who reported the issue)
>> >
>> > I just re-based it against current code.
>>
>> Isn't that code required? We do need plugin_debugger to be present for
>> global (indirect) debugging to work. I suppose it may not be required
>> for direct debugging, but I haven't tested that.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][Patch] To fix the issue in Debugger module
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Tidy up About box formatting,'cos it's been annoying