Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

Поиск
Список
Период
Сортировка
От Murtuza Zabuawala
Тема Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons
Дата
Msg-id CAKKotZRv4M1cpmTiWoShGVDhWOZwbrDQ5WZX=ttNtZJdVPYuVg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi Dave,

On Fri, Sep 15, 2017 at 6:26 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

PFA minor patch to fix the font-awesome icon layout issue, attaching screenshot of an issue for your reference.

Regression of your commit: Link

I'm not sure this is the right way to fix this. We should re-add the left hand margin on the buttonbar menus and top-level menus. That's consistent with what the context menu looks like, but more importantly it's also consistent with (at least) macOS. 
​This is a workaround until we have proper icons for menu. 

If we add the margin again then Menu doesn't look good with so much whitespace.
If you like that way then I'm attaching the patch for the same which will add margins again as they were before icons. ​
 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standardset f
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f