Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

On 29-Jun-2016, at 3:54 pm, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch to fix the issue of jsonb type rendering issue in runtime.
RM#1404

I'm not convinced this is a good fix for a couple of reasons:

1) You're only applying the fix if we're running in the runtime. The
runtime uses the Webkit engine just as Safari and Chrome do, so I'm
more inclined to believe this is a version specific issue, rather than
something that is definitely confined to the runtime.

2) What if the user has JSON data in a json field? Or worse, a text field?

I wonder if we could/should mark the contents of all text fields as
CDATA to prevent the browser trying to do anything with them.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company