Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node

Поиск
Список
Период
Сортировка
От Murtuza Zabuawala
Тема Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node
Дата
Msg-id CAKKotZQw1LBgGVc3+WL4YOoy84z0P75UsOuneZe9+B0Vr77H=Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents doesnot updates when user perform Refresh operation on the node  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents doesnot updates when user perform Refresh operation on the node  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Akshay,

I've tested and found one issue,

Steps:
1) Expand to any Table (eg: 'abc') with a Trigger ('trig_on_abc')
2) Right click on that 'trig_on_abc' trigger and open "Properties" dialog, Goto > "Definition" tab
3) Toggle the value of 'Trigger enabled?'
4) Go to the modified "SQL" tab and just copy the generated SQL & close the dialog (do not save, just close it)
5) Open the "Query tool" on the same and paste the SQL from the previous step and execute it (commit it)
6) Now again goto that 'trig_on_abc' in the browser tree and right click and refresh.
7) You will see that icon is not getting updated on the "Refresh", though I'm receiving proper icon in the response.
(Attaching the screenshot)

Expected: Let's say If I've disabled the Trigger via SQL then Disable trigger icon should get reflected when we Refresh.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Aug 13, 2018 at 6:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Mon, Aug 13, 2018 at 12:01 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3461 "Properties/SQL panel contents does not updates when user perform Refresh operation on the node". Please review it.


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents doesnot updates when user perform Refresh operation on the node
Следующее
От: Ashesh Vashi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents doesnot updates when user perform Refresh operation on the node