Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module
От | Murtuza Zabuawala |
---|---|
Тема | Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module |
Дата | |
Msg-id | CAKKotZQW_mon2uoH2nOY5MGgtH6_TofVsdOMDFohBb+TiGktaw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module (Dave Page <dpage@pgadmin.org>) |
Ответы |
Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module
(Dave Page <dpage@pgadmin.org>)
|
Список | pgadmin-hackers |
Hi Dave,
On Fri, Jan 26, 2018 at 10:33 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add 'pycodestyle ' (formerly called pep8) which is a Python PEP-8 checker module.Nice!A couple of thoughts:- I think this should go into web/regression/requirements.txt. Otherwise, it'll end up being installed in the packages we build.
I have come up with new design for requirements (Patch attached).
We can have layered requirement files, f
or example, we can have all the common dependancies in one file
say
requirements/
common.txt, then
we can have
requirements/
requirements-
dev
.txt which will inherit all the common dependancies from
common.txt plus it has its own development related
dependancies, similar with
requirements/
requirements.txt
which will inherit all the common dependancies from
common.txt plus it has its own production related
dependancies(if any),
Then we can use pip install -r
requirements/
requirements-
dev.txt
for the development
and
pip install -r
requirements/requirements.txt
for the production
accordingly without interfering between them.
- We should probably include a new Makefile target to run it, as well as including it in the "check" target.
Sorry, I didn't get you on this one, could you please throw some light on this?
- Once we expect the output to be clean, I think we should add a runner script to ci/ so we automate checking.
Yes, we should
.
- Would a shorter output be more useful? In particular, it seems to be outputting a paragraph of text every time if finds a line longer than 79 chars. Really, we just need the location of each issue, and then the summary I think, e.g.
Done.
FYI you can configure it via show-source (displays faulty code) & show-pep8
(displays corrective
suggestions
)
options
in web/.pycodestyle......./pgadmin/utils/tests/test_versioned_template_loader.py:127: [E501] line too long (104 > 79 characters) ./pgadmin/utils/tests/test_versioned_template_loader.py:118: [E501] line too long (89 > 79 characters) ./pgadmin/utils/tests/test_versioned_template_loader.py:116: [E501] line too long (89 > 79 characters) 3 E111 indentation is not a multiple of four52 E121 continuation line under-indented for hanging indent19 E122 continuation line missing indentation or outdented27 E123 closing bracket does not match indentation of opening bracket's line3 E124 closing bracket does not match visual indentation6 E125 continuation line with same indent as next logical line79 E126 continuation line over-indented for hanging indent67 E127 continuation line over-indented for visual indent15 E128 continuation line under-indented for visual indent3 E129 visually indented line with same indent as next logical line11 E131 continuation line unaligned for hanging indent6 E203 whitespace before ','1 E211 whitespace before '['2 E221 multiple spaces before operator1 E222 multiple spaces after operator19 E225 missing whitespace around operator19 E226 missing whitespace around arithmetic operator16 E231 missing whitespace after ','2 E241 multiple spaces after ','7 E251 unexpected spaces around keyword / parameter equals1 E261 at least two spaces before inline comment1 E271 multiple spaces after keyword17 E302 expected 2 blank lines, found 123 E303 too many blank lines (2)14 E305 expected 2 blank lines after class or function definition, found 11 E401 multiple imports on one line1176 E501 line too long (80 > 79 characters)15 E502 the backslash is redundant between brackets4 E703 statement ends with a semicolon8 E712 comparison to False should be 'if cond is False:' or 'if not cond:'3 E713 test for membership should be 'not in'21 E722 do not use bare except'1 E741 ambiguous variable name 'l'11 W391 blank line at end of file23 W503 line break before binary operator1677Thoughts?
Please review.
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: pgAdmin 4 JenkinsДата:
Сообщение: Jenkins build is back to normal : pgadmin4-master-python35 #460
Следующее
От: Anthony DeBarrosДата:
Сообщение: Re: Request for feedback: Alternate desktop runtime architecture