On Fri, 11 Jan 2019 at 06:56, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Pushed 0001 with some minor tweaks, thanks.
Thanks for pushing. I had looked at 0001 last night and there wasn't
much to report, just:
v12 0001
1. I see you've moved translate_col_privs() out of prepunion.c into
appendinfo.c. This required making it an external function, but it's
only use is in inherit.c, so would it not be better to put it there
and keep it static?
2. The following two lines I think need to swap their order.
+#include "utils/rel.h"
+#include "utils/lsyscache.h"
Both are pretty minor details but thought I'd post them anyway.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services