Re: Patch to improve a few appendStringInfo* calls

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Patch to improve a few appendStringInfo* calls
Дата
Msg-id CAKJS1f8acVwM-dsPn1rfOj+pmwLLXOBsPoUKteO4iURzuzfCTg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch to improve a few appendStringInfo* calls  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Patch to improve a few appendStringInfo* calls  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On 22 December 2015 at 01:58, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Jul 2, 2015 at 6:08 AM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
>> I left out the changes like
>>
>>> -               appendStringInfoString(&collist, buf.data);
>>> +               appendBinaryStringInfo(&collist, buf.data, buf.len);
>>
>>
>> because they're not an improvement in readablity, IMHO, and they were not
>> in performance-critical paths.
>
> Perhaps we can come up with appendStringInfoStringInfo at some later date.

concatenateStringInfo?


 According to grep -rE "appendStringInfoString\(.*\.data\);" . we have 13 such matches. None of them seem to be in very performance critical places, perhaps with the exception of xmlconcat().

Would you say that we should build a macro to wrap up a call to appendBinaryStringInfo() or invent another function which looks similar?


--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types
Следующее
От: Haribabu Kommi
Дата:
Сообщение: Re: Parallel Aggregate